Daniel Erez has posted comments on this change. Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/42061/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java: Line 109: setSucceeded(true); Line 110: } Line 111: Line 112: protected SnapshotDao getSnapshotDao() { Line 113: return DbFacade.getInstance().getSnapshotDao(); No need to call DbFacade after using @Inject annotation... Any why, are you using SnapshotDao at all here? Line 114: } Line 115: Line 116: @Override Line 117: public List<PermissionSubject> getPermissionCheckSubjects() { -- To view, visit https://gerrit.ovirt.org/42061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36d1c3278c4d251a15ee42b67d5c9fa8177c0e20 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
