Maor Lipchuk has posted comments on this change. Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand ......................................................................
Patch Set 19: (3 comments) https://gerrit.ovirt.org/#/c/42061/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java: Line 87: protected void endSuccessfully() { Line 88: if (!getParameters().isParentHasTasks()) { Line 89: getBackend().endAction(getParameters().getParentCommand(), Line 90: getParameters().getParentParameters(), Line 91: getContext().clone().withoutCompensationContext().withoutExecutionContext().withoutLock()); > use CommandBase -> cloneContextAndDetachFromParent Done Line 92: } Line 93: setSucceeded(true); Line 94: } Line 95: Line 98: if (!getParameters().isParentHasTasks()) { Line 99: getParameters().getParentParameters().setTaskGroupSuccess(false); Line 100: getBackend().endAction(getParameters().getParentCommand(), Line 101: getParameters().getParentParameters(), Line 102: getContext().clone().withoutCompensationContext().withoutExecutionContext().withoutLock()); > same Done Line 103: } Line 104: setSucceeded(true); Line 105: } Line 106: Line 103: } Line 104: setSucceeded(true); Line 105: } Line 106: Line 107: protected SnapshotDao getSnapshotDao() { > use @Inject instead Done Line 108: return DbFacade.getInstance().getSnapshotDao(); Line 109: } Line 110: Line 111: @Override -- To view, visit https://gerrit.ovirt.org/42061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36d1c3278c4d251a15ee42b67d5c9fa8177c0e20 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
