Moti Asayag has posted comments on this change. Change subject: core[BE]: Adding external status to BE ......................................................................
Patch Set 4: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/42133/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java: Line 71: int result = 1; Line 72: result = prime * result + ((id == null) ? 0 : id.hashCode()); Line 73: result = prime * result + ((availableDiskSize == null) ? 0 : availableDiskSize.hashCode()); Line 74: result = prime * result + ((usedDiskSize == null) ? 0 : usedDiskSize.hashCode()); Line 75: result = prime * result you can use Objects.hashCode() Line 76: + ((externalStatus == null) ? 0 : externalStatus.hashCode()); Line 77: return result; Line 78: } Line 79: Line 91: StorageDomainDynamic other = (StorageDomainDynamic) obj; Line 92: return (ObjectUtils.objectsEqual(id, other.id) Line 93: && ObjectUtils.objectsEqual(availableDiskSize, other.availableDiskSize) Line 94: && ObjectUtils.objectsEqual(usedDiskSize, other.usedDiskSize) Line 95: && ObjectUtils.objectsEqual(externalStatus, other.externalStatus)); you can use Objects.equals() Line 96: } -- To view, visit https://gerrit.ovirt.org/42133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2141005b16c7a43009f0f5d422687f24781e402e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
