Eli Mesika has posted comments on this change. Change subject: core[BE]: Adding external status to BE ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42133/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java: Line 20: this.setStatus(status); Line 21: } Line 22: Line 23: private StoragePoolIsoMapId id; Line 24: private ExternalStatus externalStatus; > Should also be part of the hashCode and equals methods, like status. Will add BTW we are now moving entities to use JPA and those methods will use only the logical IDs in near future Line 25: Line 26: @Override Line 27: public StoragePoolIsoMapId getId() { Line 28: return this.id; -- To view, visit https://gerrit.ovirt.org/42133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2141005b16c7a43009f0f5d422687f24781e402e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
