Omer Frenkel has posted comments on this change. Change subject: backend: Enable granular hostdev passthrough support ......................................................................
Patch Set 7: Code-Review+1 (1 comment) just a comment on unclear method https://gerrit.ovirt.org/#/c/42159/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RemoveVmHostDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RemoveVmHostDevicesCommand.java: Line 69: Line 70: setSucceeded(true); Line 71: } Line 72: Line 73: private static boolean allPlaceholder(Collection<VmHostDevice> devices) { method name is not clear, and its not clear what this return Line 74: for (VmHostDevice device : devices) { Line 75: if (!device.isIommuPlaceholder()) { Line 76: return false; Line 77: } -- To view, visit https://gerrit.ovirt.org/42159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c8a80adce97ef98174bd85ac75f09dfe2a36de9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
