Martin Betak has posted comments on this change. Change subject: backend: Enable granular hostdev passthrough support ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42159/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java: Line 109: } Line 110: Line 111: protected boolean hasIommu(HostDevice hostDevice) { Line 112: // iommu group restriction only applicable to 'pci' devices Line 113: return CAPABILITY_PCI.equals(hostDevice.getCapability()) || hostDevice.getIommuGroup() == null; note to self: since the condition was inverted there should be && and != null Line 114: } Line 115: Line 116: private HostDevice fetchHostDevice(String deviceName) { Line 117: return hostDeviceDao.getHostDeviceByHostIdAndDeviceName(getVm().getDedicatedVmForVds(), deviceName); -- To view, visit https://gerrit.ovirt.org/42159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c8a80adce97ef98174bd85ac75f09dfe2a36de9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
