[Engine-patches] Change in ovirt-engine[master]: restapi: Implementation for GuestOsInfo and Timezone reporting

[juan . hernandez]

Juan Hernandez has posted comments on this change.

Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

Looks good, only some minor comments.

https://gerrit.ovirt.org/#/c/41813/7/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java:

Line 417: 
Line 418:             final boolean hasGuestOsVersion = 
entity.getGuestOsVersion() != null && !entity.getGuestOsVersion().isEmpty();
Line 419:             final boolean hasTimezoneName = 
entity.getGuestOsTimezoneName() != null && 
!entity.getGuestOsTimezoneName().isEmpty();
Line 420:             if (hasGuestOsVersion) {
Line 421:                 GuestOperatingSystem os = new GuestOperatingSystem();
Try to respect a possible existing "GuestOperatingSystem":

  GuestOperatingSystem os = model.getGuestOperatingSystem();
  if (os == null) {
    os = new GuestOperatingSystem();
    model.setGuestOperatingSystem(os);
  }
  os.setWhatever(...);
  ...
Line 422:                 os.setArchitecture(entity.getGuestOsArch().name());
Line 423:                 os.setCodename(entity.getGuestOsCodename());
Line 424:                 os.setDistribution(entity.getGuestOsDistribution());
Line 425:                 os.setKernel(new Kernel());


Line 434:                 model.setGuestOperatingSystem(os);
Line 435:             }
Line 436: 
Line 437:             if (hasTimezoneName) {
Line 438:                 model.setGuestTimeZone(new TimeZone());
Same as above, but for the "TimeZone".
Line 439:                 
model.getGuestTimeZone().setName(entity.getGuestOsTimezoneName());
Line 440:                 
model.getGuestTimeZone().setUtcOffset(mapUtcOffsetToDisplayString(entity.getGuestOsTimezoneOffset()));
Line 441:             }
Line 442: 


-- 
To view, visit https://gerrit.ovirt.org/41813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I492d42248858fc653918a33e972734bd82be1eec
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches