Juan Hernandez has posted comments on this change.
Change subject: restapi: openstack_volume_type on Disk entity
......................................................................
Patch Set 1:
If we are planning to remove the "volume_types" collection in 4.0 I'd consider
removing it from 3.6 as well, unless there is a real use case where it is
actually needed. In general, if we are planning to change the design of the
integration for 4.0 then I wouldn't introduce that collection, the provider, or
this field at all in 3.6, unless there is a real need.
Then, for this new field, you can use a plain string as you initially proposed.
Another alternative, if there are chances that the "volume_types" collection
will survive, is to use a nested name, containing a plain string:
<openstack_volume_type>
<name>mytype</name>
</openstack_volume_type>
This gives as room for adding the link if required.
--
To view, visit https://gerrit.ovirt.org/41966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I952c431b8f7e7d0508855892b518c43bef9c7b7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
