Juan Hernandez has posted comments on this change.

Change subject: restapi: openstack_volume_type on Disk entity
......................................................................


Patch Set 1:

For output consider using a link to the existing volume type resource:

  <openstack_volume_type id="123" 
href="/opentstackvolumeproviders/456/volumetypes/123"/>

For input it is good to accept both the id and the name, if both are unique:

  <openstack_volume_type id="123"/>

  <openstack_volume_type>
    <name>mytype</name>
  </openstack_volume_type>

If they aren't unique then we will need to require the identifier (or name) of 
the provider as well:

  <openstack_volume_type>
    <name>mytype</name>
    <openstack_volume_provider id="123"/>
  </openstack_volume_type>

-- 
To view, visit https://gerrit.ovirt.org/41966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I952c431b8f7e7d0508855892b518c43bef9c7b7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to