Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: offering files of unknown type as candidates for kernel and initrd images ......................................................................
webadmin: offering files of unknown type as candidates for kernel and initrd images • to keep things simple, when refreshing list of images, ALL type is used to refresh all files (since there's no way how to tell vdsm 'refresh all files but ...'), but only images of type UNKNOWN are presented to the user, since there's not specific type for kernel initrd images and we know, that we do not want to offer them iso's, floppies, or others. To do that, RepoImageToImageFileNameAsyncConverter converter callback was altered to allow filtering. Subclass used for obtaining images of UNKNOWN type then can query all and filter unwanted by that type. • when passing image name back to backend, it must start with prefix 'iso://' otherwise root of iso domain for given data-center won't be added before selected filename. To do that, RepoImageToImageFileNameAsyncConverter converter callback was altered to provide overridable method for converting each record, and subclass of this callback used for obtaining images of UNKNOWN type prepends "iso://" prefix to image name. That way, all images in comboboxes starts with 'iso://', which may seem ackward at first, but it offers clear distinction, that this is the image from iso domain Note: technically run once dialog coud use only one call to get all images, categorize them by type and use where approriate, instead of current three calls, and refreshed could refresh files of specific type(when type's known) or all files (where it's unknown), but that would be harder to implement in given time window, so easier solution was selected. Bug-Url: https://bugzilla.redhat.com/1200952 Change-Id: Ic5ce60fb187fbfd6efe1b6e497f21157bd7a9484 Signed-off-by: Martin Mucha <mmu...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 4 files changed, 184 insertions(+), 79 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified -- To view, visit https://gerrit.ovirt.org/41358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ce60fb187fbfd6efe1b6e497f21157bd7a9484 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
