Daniel Erez has posted comments on this change. Change subject: core: introduce LibvirtSecretDao ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/41551/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java: Line 14: * Line 15: * @param id the id Line 16: * @return the engine secret Line 17: */ Line 18: LibvirtSecret get(Guid id); > You already got add interface, you can remove it I think Done Line 19: Line 20: /** Line 21: * Retrieves all secrets for the specified provider id. Line 22: * -- To view, visit https://gerrit.ovirt.org/41551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33625086f2f7bcaef755b8e75b8ba07f688f33b2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
