Daniel Erez has posted comments on this change. Change subject: core: introduce LibvirtSecretDao ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41551/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java: Line 7: Line 8: /** Line 9: * <code>LibvirtSecretDao</code> defines a type which performs CRUD operations on instances of {@link LibvirtSecret}. Line 10: */ Line 11: public interface LibvirtSecretDao extends DAO, GenericDao<LibvirtSecret, Guid> { > What about my last comment Done Line 12: /** Line 13: * Retrieves the secret with the specified id. Line 14: * Line 15: * @param id the id -- To view, visit https://gerrit.ovirt.org/41551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33625086f2f7bcaef755b8e75b8ba07f688f33b2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches