Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Fix cascade delete with Job/Step ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/41912/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java: Line 127: updateJob updateJob and its imp method are not used by any code in this patch https://gerrit.ovirt.org/#/c/41912/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java: Line 127: : @Override : public void loadJobSteps(final Job job) { : // Nothing to do - JPA handles this for us : } if this method has no meaning any more why don't you remove that from the interface? https://gerrit.ovirt.org/#/c/41912/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java: Line 53: : : : : : : : : Why did you remove the test? -- To view, visit https://gerrit.ovirt.org/41912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53021c91c138059816e58c4f25bb2851f6c29800 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
