Allon Mureinik has posted comments on this change.
Change subject: core: adding unlock_entity.sh script(#868638)
......................................................................
Patch Set 15: (3 inline comments)
basically +1.
Gave only 0 due to question inline (the quotes issue - not sure this is
required) - pending answer.
If it is not, I'll modify my review to +1.
Also, when you rebase, please fix the minor issue in the commit message.
....................................................
File backend/manager/dbscripts/unlock_entity.sh
Line 59: fi
Line 60: fi
Line 61:
Line 62: if [[ -n "${TYPE}" && -n "${ID}" ]]; then
Line 63: unlock_entity "${TYPE}" "${ID}" "$(whoami)" ${RECURSIVE}
doesn't ${RECURSIVE} need quotes too?
Line 64: elif [[ -n "${TYPE}" && -n "${QUERY}" ]]; then
Line 65: query_locked_entities "${TYPE}"
Line 66: else
Line 67: usage
....................................................
Commit Message
Line 34: The operation is logged as an Alert in the audit_log with all relevant
Line 35: details.
Line 36:
Line 37: Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Line 38: Signed-off-by: Eli Mesika <emes...@redhat.com>
Please remove this redundant field - you have one bellow...
Line 39: Bug-Url:https://bugzilla.redhat.com/868638
Line 36:
Line 37: Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Line 38: Signed-off-by: Eli Mesika <emes...@redhat.com>
Line 39: Bug-Url:https://bugzilla.redhat.com/868638
Line 40: Signed-off-by: Eli Mesika <emes...@redhat.com>
... here.
--
To view, visit http://gerrit.ovirt.org/8688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
