Allon Mureinik has posted comments on this change.
Change subject: core: adding unlock_entity.sh script(#868638)
......................................................................
Patch Set 12: (3 inline comments)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 384: log_unlock_entity() {
Line 385: local object_type=${1}
Line 386: local id=${2}
Line 387: local user=${3}
Line 388: msg="System user ${user} run unlock_entity script on
${object_type} ${id} with db user ${USERNAME}"
Consider using "OS" instead of "System" - I think it will be less confusing.
Line 389: CMD="insert into
audit_log(log_time,log_type_name,log_type,severity,message)
Line 390: values(now(), 'USER_RUN_UNLOCK_ENTITY_SCRIPT', 2024, 10,
'${msg}')"
Line 391: execute_command "${CMD}" "${DATABASE}" "${SERVERNAME}" "${PORT}"
Line 392: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 165: USER_ADD_DISK(2020),
Line 166: USER_ADD_DISK_FINISHED_SUCCESS(2021),
Line 167: USER_ADD_DISK_FINISHED_FAILURE(2022),
Line 168: USER_FAILED_ADD_DISK(2023),
Line 169: // Used only from SQL script, therefor should not have severity &
message
wouldn't this generate a warning when JBoss comes up?
Line 170: USER_RUN_UNLOCK_ENTITY_SCRIPT(2024),
Line 171:
Line 172: // Quota audit logs
Line 173: USER_ADD_QUOTA(3000),
....................................................
Commit Message
Line 30: The operation is logged as an Alert in the audit_log with all relevant
Line 31: details.
Line 32:
Line 33: Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Line 34: Signed-off-by: Eli Mesika <emes...@redhat.com>
One of these should be enough :-)
Line 35: Bug-Url:https://bugzilla.redhat.com/868638
--
To view, visit http://gerrit.ovirt.org/8688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
