Tomas Jelinek has posted comments on this change. Change subject: webadmin: add memory device type icon ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42127/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java: Line 396: @Source("images/device_hostdev.png") Line 397: ImageResource hostdevDeviceGeneralTypeIcon(); Line 398: Line 399: @Source("images/memory_icon.png") Line 400: ImageResource MemoryDeviceGeneralTypeIcon(); this is a method so should follow the java method naming conventions (e.g. lowercase "m") -- To view, visit https://gerrit.ovirt.org/42127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1478523462add1f8097ac83f0868ce6246fd5e93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
