Omer Frenkel has uploaded a new change for review. Change subject: webadmin: add memory device type icon ......................................................................
webadmin: add memory device type icon new icon for new device type (used in vm devices sub tab) Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224886 Change-Id: I1478523462add1f8097ac83f0868ce6246fd5e93 Signed-off-by: Omer Frenkel <ofren...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/42127/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 31241b2..9fee039 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -2224,6 +2224,9 @@ @DefaultStringValue("Host Device") String hostdevDeviceGeneralType(); + @DefaultStringValue("Memory") + String memoryDeviceGeneralType(); + @DefaultStringValue("Unknown") String unknownDeviceGeneralType(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java index 7217a9b..d0089bb 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java @@ -395,4 +395,7 @@ @Source("images/device_hostdev.png") ImageResource hostdevDeviceGeneralTypeIcon(); + + @Source("images/memory_icon.png") + ImageResource MemoryDeviceGeneralTypeIcon(); } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java index c80d487..d34a6c8 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java @@ -49,6 +49,8 @@ return resources.watchdogDeviceGeneralTypeIcon(); case HOSTDEV: return resources.hostdevDeviceGeneralTypeIcon(); + case MEMORY: + return resources.MemoryDeviceGeneralTypeIcon(); case UNKNOWN: return resources.questionMarkImage(); } @@ -117,6 +119,8 @@ return SafeHtmlUtils.fromTrustedString(constants.watchdogDeviceGeneralType()); case HOSTDEV: return SafeHtmlUtils.fromTrustedString(constants.hostdevDeviceGeneralType()); + case MEMORY: + return SafeHtmlUtils.fromTrustedString(constants.memoryDeviceGeneralType()); case UNKNOWN: return SafeHtmlUtils.fromTrustedString(constants.unknownDeviceGeneralType()); } -- To view, visit https://gerrit.ovirt.org/42127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1478523462add1f8097ac83f0868ce6246fd5e93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
