Sahina Bose has posted comments on this change. Change subject: gluster: Alert if volume snapshot max limit reached ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41814/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java: Line 385: You could refactor to combine these similar methods - alertVolumeSnapshotHardLimitReached and alertVolumeSnapshotSoftLimitReached as private boolean alertVolumeLimitReached(final GlusterVolumeEntity volume, boolean checkHardLimit) https://gerrit.ovirt.org/#/c/41814/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java: Line 220: the comment to be removed? -- To view, visit https://gerrit.ovirt.org/41814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98920caac7e194f8887c0226399ff59fe2942cd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
