Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Alert if volume snapshot max limit reached ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41814/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java: Line 354: DbFacade.getInstance() Line 355: .getAuditLogDao() Line 356: .getByVolumeIdAndType(volume.getId(), Line 357: checkHardLimit ? AuditLogType.GLUSTER_VOLUME_SNAPSHOT_HARD_LIMIT_REACHED.getValue() Line 358: : AuditLogType.GLUSTER_VOLUME_SNAPSHOT_SOFT_LIMIT_REACHED.getValue()); > not so important, but for readability, you could define Done Line 359: if (!limitAlerts.isEmpty()) { Line 360: for (AuditLog alert : limitAlerts) { Line 361: if (!alert.isDeleted()) { Line 362: return true; -- To view, visit https://gerrit.ovirt.org/41814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98920caac7e194f8887c0226399ff59fe2942cd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
