Daniel Erez has posted comments on this change. Change subject: core: Remove Cinder disk should remove all volume types. ......................................................................
Patch Set 8: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/42058/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java: Line 308: removeLunDisk(); Line 309: break; Line 310: case CINDER: Line 311: RemoveCinderDiskParameters params = new RemoveCinderDiskParameters(getParameters().getDiskId()); Line 312: if ( ((CinderDisk)getDisk()).getImageStatus() == ImageStatus.ILLEGAL) { use formatter Line 313: params.setFaultTolerant(true); Line 314: } Line 315: Line 316: Future<VdcReturnValueBase> future = CommandCoordinatorUtil.executeAsyncCommand( -- To view, visit https://gerrit.ovirt.org/42058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176b0b01d43fc6b9eab051dc93e6bb0a11fb934b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
