Daniel Erez has posted comments on this change. Change subject: core: Remove Cinder disk should remove all volume types. ......................................................................
Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/42058/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java: Line 82: } Line 83: return cinderDisk; Line 84: } Line 85: Line 86: private VolumeClassification removeCinderVolume(CinderDisk volume) { change to void Line 87: VolumeClassification cinderVolumeType = volume.getVolumeClassification(); Line 88: if (cinderVolumeType == VolumeClassification.Volume) { Line 89: getCinderBroker().deleteDisk(volume); Line 90: } else if (cinderVolumeType == VolumeClassification.Snapshot) { Line 101: updated s/updated/lastSnapshot Line 114: ( check if updated can be null Line 228: ""; use StringUtils.EMPTY -- To view, visit https://gerrit.ovirt.org/42058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176b0b01d43fc6b9eab051dc93e6bb0a11fb934b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
