Arik Hadas has posted comments on this change. Change subject: core: introduce import from external provider ......................................................................
Patch Set 65: (1 comment) https://gerrit.ovirt.org/#/c/33712/65/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java: Line 92: if (!validateBallonDevice()) { Line 93: return false; Line 94: } Line 95: Line 96: if (!validateNoDuplicateVm()) { > you should also call canAddVm() (and sometime later we need to rename it) t Done (I renamed it before reading the comment..) Line 97: return false; Line 98: } Line 99: Line 100: if (!validateVmArchitecture()) { -- To view, visit https://gerrit.ovirt.org/33712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9328edf7b8f49aa7975e28f651183b1449030dd6 Gerrit-PatchSet: 65 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
