Arik Hadas has posted comments on this change. Change subject: core: introduce import from external provider ......................................................................
Patch Set 60: (2 comments) https://gerrit.ovirt.org/#/c/33712/60/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java: Line 75: if (!getStorageDomain().getStoragePoolId().equals(getStoragePoolId())) { Line 76: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_AND_CLUSTER_IN_DIFFERENT_POOL); Line 77: } Line 78: Line 79: if (getStoragePool().getStatus() != StoragePoolStatus.Up) { > no need to verify storage domain is up as well? Done Line 80: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_STATUS_ILLEGAL); Line 81: } Line 82: Line 83: if (getVdsId() != null && !validate(validateRequestedProxyHost())) { Line 107: return ValidationResult.VALID; Line 108: } Line 109: Line 110: @Override Line 111: protected List<DiskImage> createDiskDummiesForSpaceValidations(List<DiskImage> disksList) { > i dont think this is called currently Done Line 112: List<DiskImage> dummies = new ArrayList<>(disksList.size()); Line 113: for (DiskImage image : disksList) { Line 114: dummies.add(ImagesHandler.createDiskImageWithExcessData(image, getStorageDomainId())); Line 115: } -- To view, visit https://gerrit.ovirt.org/33712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9328edf7b8f49aa7975e28f651183b1449030dd6 Gerrit-PatchSet: 60 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
