Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: pki: Prompt before renewal
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/41876/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py:

Line 32: 
Line 33: from ovirt_engine_setup import constants as osetupcons
Line 34: from ovirt_engine_setup import util as osetuputil
Line 35: from ovirt_engine_setup import dialog
Line 36: from ovirt_engine_setup.engine import constants as oenginecons
please keep the import list sorted, in patchset #2 it was correctly right after 
the import constants
Line 37: from ovirt_engine_setup.engine import vdcoption
Line 38: from ovirt_engine_setup.engine_common import constants as oengcommcons
Line 39: 
Line 40: 


-- 
To view, visit https://gerrit.ovirt.org/41876
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idca01632ac1ea7895bba54d7f3f8bb0d9b2c90d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to