Arik Hadas has posted comments on this change. Change subject: core: introduce convert vm command ......................................................................
Patch Set 95: (1 comment) https://gerrit.ovirt.org/#/c/33055/95/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java: Line 110: switch (getActionState()) { Line 111: case EXECUTE: Line 112: if (getSucceeded()) { Line 113: return AuditLogType.IMPORTEXPORT_STARTING_CONVERT_VM; Line 114: } > but what about failure? then AuditLogType.IMPORTEXPORT_IMPORT_VM_FAILED will be returned (line 120) Line 115: case END_SUCCESS: Line 116: if (getSucceeded()) { Line 117: return AuditLogType.IMPORTEXPORT_IMPORT_VM; Line 118: } -- To view, visit https://gerrit.ovirt.org/33055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Gerrit-PatchSet: 95 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
