Arik Hadas has posted comments on this change. Change subject: core: introduce convert vm command ......................................................................
Patch Set 94: (1 comment) https://gerrit.ovirt.org/#/c/33055/94/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java: Line 70: cachedCallback = new ConvertVmCallback(getCommandId()); Line 71: // if the callback is created after the command was executed, it means that the engine restarted Line 72: // so there is no v2v-job in vdsManager and thus we add a new job with unknown status there Line 73: if (getCommandExecutionStatus() == CommandExecutionStatus.EXECUTED) { Line 74: getVdsManager().addV2VJobInfoForVm(getVmId(), JobStatus.UNKNOWN); > so far the bll is working with the resource manager as a service that it ex I see, so it is not a matter of procedural programming vs object oriented programming, but a matter of whether it breaks the design principles for the interaction of bll and vdsbroker or not. What do you suggest? the jobs are monitored by the monitoring which resides in vdsbroker and I need to access it when a command is restored - this is handled in bll. I wouldn't want to generalize it again to serve as some kind of infra, but to keep it specific for v2v. Please advice. Line 75: } Line 76: } Line 77: return cachedCallback; Line 78: } -- To view, visit https://gerrit.ovirt.org/33055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Gerrit-PatchSet: 94 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
