Eli Mesika has posted comments on this change. Change subject: core : Support tokens with special characters ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41832/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 380: Matcher m = adSearchPattern.matcher(searchText); Line 381: // checks if this is a AD query, if it is, verify given profile and namespace and pass the query Line 382: if (m.matches()) { Line 383: final String COLON = ":"; Line 384: String matched = m.group("content"); > No need for temp variable, just assign it to searchText Done Line 385: String prefix = m.group("prefix"); Line 386: searchText = matched; Line 387: // get profile Line 388: List<String> profiles = getBackend().runInternalQuery(VdcQueryType.GetDomainList, Line 418: searchText = prefix + COLON + searchText; Line 419: } Line 420: curSyntaxChecker = SyntaxCheckerFactory.createADSyntaxChecker(Config Line 421: .<String>getValue(ConfigValues.AuthenticationMethod)); Line 422: > What's this empty line for? Done Line 423: } else { Line 424: curSyntaxChecker = SyntaxCheckerFactory Line 425: .createBackendSyntaxChecker(Config.<String>getValue(ConfigValues.AuthenticationMethod)); Line 426: } -- To view, visit https://gerrit.ovirt.org/41832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2464227376eb2e6ee0b5ada2ced21278675b7572 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
