Eli Mesika has posted comments on this change. Change subject: core : Support tokens with special characters ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41832/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 336: }); Line 337: } Line 338: Line 339: private static final String[] AD_SEARCH_TYPES = { Line 340: SearchObjects.AD_USER_OBJ_NAME, > Please fix formatting Done Line 341: SearchObjects.AD_USER_PLU_OBJ_NAME, Line 342: SearchObjects.AD_GROUP_OBJ_NAME, Line 343: SearchObjects.AD_GROUP_PLU_OBJ_NAME Line 344: }; Line 381: // checks if this is a AD query, if it is, verify given profile and namespace and pass the query Line 382: if (m.matches()) { Line 383: final char COLON = ':'; Line 384: String matched = m.group("content"); Line 385: String prefix = searchText.substring(0, searchText.length() - matched.length() - 1) + COLON; > Sorry, I missed you need also prefix. Please change regex to: Done Line 386: searchText = matched; Line 387: // get profile Line 388: List<String> profiles = getBackend().runInternalQuery(VdcQueryType.GetDomainList, Line 389: new VdcQueryParametersBase()).getReturnValue(); -- To view, visit https://gerrit.ovirt.org/41832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2464227376eb2e6ee0b5ada2ced21278675b7572 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
