Alexander Wels has posted comments on this change.

Change subject: frontend: consider Everyone->diskProfileUser as basic user 
permission
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41834/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java:

Line 21: import org.ovirt.engine.ui.uicompat.EventArgs;
Line 22: import org.ovirt.engine.ui.uicompat.FrontendMultipleQueryAsyncResult;
Line 23: import 
org.ovirt.engine.ui.uicompat.IFrontendMultipleQueryAsyncCallback;
Line 24: 
Line 25: import static org.ovirt.engine.ui.uicommonweb.auth.ApplicationGuids.*;
Don't do import something.*. Explicitly import the parts you want.
Line 26: import static 
org.ovirt.engine.ui.uicommonweb.auth.ApplicationGuids.everyone;
Line 27: 
Line 28: public class UserPortalLoginModel extends LoginModel
Line 29: {


-- 
To view, visit https://gerrit.ovirt.org/41834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to