Maor Lipchuk has posted comments on this change. Change subject: core: introduce libvirt_secrets table ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/41550/3/packaging/dbscripts/upgrade/03_06_1460_libvirt_secrets.sql File packaging/dbscripts/upgrade/03_06_1460_libvirt_secrets.sql: Line 3: -- ---------------------------------------------------------------------- Line 4: Line 5: CREATE TABLE libvirt_secrets Line 6: ( Line 7: secret_uuid UUID NOT NULL, probably better to name the field, simply id or secret_id Line 8: secret_value TEXT NOT NULL, Line 9: secret_usage_type integer NOT NULL, Line 10: secret_description TEXT, Line 11: provider_id UUID NOT NULL, Line 6: ( Line 7: secret_uuid UUID NOT NULL, Line 8: secret_value TEXT NOT NULL, Line 9: secret_usage_type integer NOT NULL, Line 10: secret_description TEXT, no need to use all those "secret_" prefixes, since we already have this context from the table. It will just make the java mapper more verbose that way Line 11: provider_id UUID NOT NULL, Line 12: _create_date timestamp with time zone DEFAULT ('now'::text)::timestamp without time zone, Line 13: _update_date timestamp with time zone, Line 14: CONSTRAINT PK_secret_uuid PRIMARY KEY (secret_uuid), Line 14: CONSTRAINT PK_secret_uuid PRIMARY KEY (secret_uuid), Line 15: FOREIGN KEY (provider_id) REFERENCES providers(id) ON DELETE CASCADE Line 16: ); Line 17: Line 18: CREATE INDEX IDX_libvirt_secrets_provider_id ON libvirt_secrets(provider_id); Not sure about the index, but I guess it's Eli's call. -- To view, visit https://gerrit.ovirt.org/41550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588a2cea168ecd7abf0a3f92be5a1573af601281 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
