Maor Lipchuk has posted comments on this change. Change subject: core: introduce libvirt_secrets table ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41550/4/packaging/dbscripts/upgrade/03_06_1460_libvirt_secrets.sql File packaging/dbscripts/upgrade/03_06_1460_libvirt_secrets.sql: Line 3: -- ---------------------------------------------------------------------- Line 4: Line 5: CREATE TABLE libvirt_secrets Line 6: ( Line 7: secret_uuid UUID NOT NULL, What about changing the secret_uuid? also do we want to keep the default for _create_date? Line 8: secret_value TEXT NOT NULL, Line 9: secret_usage_type integer NOT NULL, Line 10: secret_description TEXT, Line 11: provider_id UUID NOT NULL, -- To view, visit https://gerrit.ovirt.org/41550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588a2cea168ecd7abf0a3f92be5a1573af601281 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
