Oved Ourfali has posted comments on this change. Change subject: core : Support tokens with special characters ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41832/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 357: } Line 358: // query not in cache or the cached entry is too old, process the Line 359: // search text. Line 360: if (!isExistsValue || IsFromYesterday) { Line 361: log.debug("ResourceManager::searchBusinessObjects(''{}'') - entered", searchText); I'd put different parts below in their own methods, to clarify better the logic done here. Also, add some documentation that explains it. Line 362: final char AT='@'; Line 363: String queryAuthz = getDefaultAuthz(); Line 364: String queryNamespace = null; Line 365: ISyntaxChecker curSyntaxChecker; https://gerrit.ovirt.org/#/c/41832/1/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java: Line 191: Regex any reason not to allow additional characters? -- To view, visit https://gerrit.ovirt.org/41832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2464227376eb2e6ee0b5ada2ced21278675b7572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
