Martin Peřina has posted comments on this change. Change subject: core: Add JPA UserTypes ......................................................................
Patch Set 12: (5 comments) https://gerrit.ovirt.org/#/c/40515/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/HbaUserType.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/HbaUserType.java: Line 28: Line 29: @SuppressWarnings("rawtypes") Line 30: @Override Line 31: public Serializable disassemble(Object val) throws HibernateException { Line 32: return (HashMap) val; Is there a reason to cast val as HashMap, when method returns Serializable? Line 33: } Line 34: Line 35: @Override Line 36: public boolean equals(Object x, Object y) throws HibernateException { Line 40: if (x == null) { Line 41: return false; Line 42: } Line 43: // TODO: Add full compare Line 44: return x.equals(y); Why not use Objects.equals()? Line 45: } Line 46: Line 47: @Override Line 48: public int hashCode(Object value) throws HibernateException { Line 45: } Line 46: Line 47: @Override Line 48: public int hashCode(Object value) throws HibernateException { Line 49: return value.hashCode(); Hmm, you check for null in equals, but not here. So wouldn't it be safer to use: return Objects.hash(value) Line 50: } Line 51: Line 52: @Override Line 53: public boolean isMutable() { https://gerrit.ovirt.org/#/c/40515/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/RpmVersionUserType.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/RpmVersionUserType.java: Same comments as for HbaUserType Line 1: package org.ovirt.engine.core.dao.jpa; Line 2: Line 3: import java.io.Serializable; Line 4: import java.sql.PreparedStatement; https://gerrit.ovirt.org/#/c/40515/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/VmRngDeviceSourceUserType.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/VmRngDeviceSourceUserType.java: Same comments as for HbaUserTypes Line 1: package org.ovirt.engine.core.dao.jpa; Line 2: Line 3: import java.io.Serializable; Line 4: import java.sql.PreparedStatement; -- To view, visit https://gerrit.ovirt.org/40515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30f76493ec72e3c2540e43bef2c095a7ed1c38aa Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
