Liran Zelkha has posted comments on this change. Change subject: core: Add JPA UserTypes ......................................................................
Patch Set 10: > Do we really need UserType for enums? From my previous experience > mapping enum using custom unique id was good solution. For details > please a look at [1] and solution 4. at [2] > > [1] > http://blog.chris-ritchie.com/2013/09/mapping-enums-with-fixed-id-in-jpa.html > [2] http://stackoverflow.com/a/18646470 I liked the UserType implementation, because it minimizes the effect on the entity code, and makes writing JPA queries easier (you pass the Enum, not the value). But since most of our Enums don't meet the forValue/getValue syntax, I drop this file from this patch. -- To view, visit https://gerrit.ovirt.org/40515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30f76493ec72e3c2540e43bef2c095a7ed1c38aa Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
