Moti Asayag has posted comments on this change. Change subject: engine: Network errors should be handled specifically ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41529/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 739: if (cachedVds.getStatus() != VDSStatus.Down) { Line 740: long timeoutToFence = calcTimeoutToFence(cachedVds.getVmCount(), cachedVds.getSpmStatus()); Line 741: if (isHostInGracePeriod(false)) { Line 742: if (cachedVds.getStatus() != VDSStatus.Connecting Line 743: && cachedVds.getStatus() != VDSStatus.Unassigned > Is this really needed once we have change in VdsBrokerCommand? no, removed after verifying it is not needed. Line 744: && cachedVds.getStatus() != VDSStatus.PreparingForMaintenance Line 745: && cachedVds.getStatus() != VDSStatus.NonResponsive) { Line 746: setStatus(VDSStatus.Connecting, cachedVds); Line 747: logChangeStatusToConnecting(timeoutToFence); -- To view, visit https://gerrit.ovirt.org/41529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0964537f91c0f3db07ef244cf41cbb1bbb58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
