Moti Asayag has posted comments on this change. Change subject: engine: Network errors should be handled specifically ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41529/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java: Line 98: @Override Line 99: protected void executeVDSCommand() { Line 100: try { Line 101: executeVdsBrokerCommand(); Line 102: } catch (VDSNetworkException ex) { > Why do we want to additional catch for networking exception? We already han It is doable, just that we already get an instance of VDSNetworkException, so creating another instance of VDSNetworkException as done in the case of XmlRpcRunTimeException is redundant. If we don't care about having the VDSNetworkException twice in the stracktrace - i'll change it according to your suggestion. Line 103: printReturnValue(); Line 104: updateNetworkException(ex, ex.getMessage()); Line 105: networkError.fire(ex); Line 106: throw ex; -- To view, visit https://gerrit.ovirt.org/41529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0964537f91c0f3db07ef244cf41cbb1bbb58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
