Arik Hadas has posted comments on this change. Change subject: core: introduce DiskContentType ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39143/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java: Line 128 Line 129 Line 130 Line 131 Line 132 > I'd keep this method and just change the implementation to check by the con Done Line 24: */ Line 25: private VmEntityType vmEntityType; Line 26: private int numberOfVms; Line 27: private ArrayList<String> vmNames; Line 28: private DiskContentType contentType; > we should have a default of Data Done Line 29: Line 30: /** Line 31: * Plugged and readOnly are of type Boolean (as opposed to boolean) since they are optional. Line 32: * In case the disk is not in a vm context, null will ensure they are invisible. -- To view, visit https://gerrit.ovirt.org/39143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
