Itamar Heim has posted comments on this change.

Change subject: core: adding timestamp to async tasks ...(#868636)
......................................................................


Patch Set 2:

allon,

but...
1. db didn't have the timestamp before this patch.
2. I couldn't find a place in the code where task start time isn't initialized 
from System.currentTimeMillis(), so my point it is misleading to have this 
field in the db, with start time by db clock, rather than by engine clock, and 
another field in engine, init by engine clock.

--
To view, visit http://gerrit.ovirt.org/8668
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a5c609083584e4ae304a3f7af7c0e3b4f9b408
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to