David Caro has posted comments on this change. Change subject: ovirt-engine mock builder job ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41586/4/jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_create-rpms.yaml File jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_create-rpms.yaml: Line 44: extra-env: | Line 45: CI_MAVEN_SETTINGS="\\${{WORKSPACE}}/artifactory-ovirt-org-settings.xml" Line 46: BUILD_JAVA_OPTS_MAVEN="-XX:MaxPermSize=512M -Dgwt.compiler.localWorkers=1" Line 47: BUILD_JAVA_OPTS_GWT="-XX:PermSize=512M -XX:MaxPermSize=1024M -Xms1024M -Xmx4096M" Line 48: extra-rpmbuild-options: 'ovirt_build_extra_flags -gs \\${{CI_MAVEN_SETTINGS}} -X' Quite important too, the extra-rpmbuild-options are key=value pairs to be passed as --define "key=value" to rpmbuild, not new params as is Line 49: jobs: Line 50: - '{project}_{version}_create-rpms-{distro}-{arch}_{trigger}' -- To view, visit https://gerrit.ovirt.org/41586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b54ec2d5f0008f94846727fa2597d9020ebf947 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
