David Caro has posted comments on this change.

Change subject: ovirt-engine mock builder job
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/41586/4/jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_create-rpms.yaml
File jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_create-rpms.yaml:

Line 1: - project:
Line 2:     name: ovirt_engine_create-rpms
Line 3:     project:
Line 4:       - ovirt-engine
Line 5:     trigger:
there's no timed trigger option in the template you use, if you want to use a 
different trigger than created or merged, you have to create a new template 
that uses it or somehow manage to parameterize the current one.

You confused the project trigger parameter with the template triggers section.
Line 6:       - timed: "H */6 * * *"
Line 7:     version:
Line 8:       - master
Line 9:     branch: master


Line 42: includes
this is lacking an indent


Line 45: "
the issue that you are seeing is because (not sure why) yaml does not like if 
you don't escape the double quotes on multiline strings


-- 
To view, visit https://gerrit.ovirt.org/41586
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b54ec2d5f0008f94846727fa2597d9020ebf947
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Barak Korren <bkor...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Max Kovgan <m...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to