Michael Pasternak has posted comments on this change.

Change subject: restapi: #864991 - Vm Custom Properties Ignored
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 207:     }
Line 208: 
Line 209:     @Override
Line 210:     public Response start(Action action) {
Line 211:         RunVmOnceParams params = map(get(), new 
RunVmOnceParams(guid));
this is unlikely to happen, because in populate() we add only items
which are not a part of vm business entity (in this case it's extra data added 
via query to public vm), so on the way back you can pass only VmStatic business 
entity content (all extra data that was added to public entity is irrelevant)
Line 212:         if (action.isSetVm()) {
Line 213:             validateEnums(VM.class, action.getVm());
Line 214:             VM vm = action.getVm();
Line 215:             params = map(vm, params);


--
To view, visit http://gerrit.ovirt.org/8706
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9c4ac782edf1779455aeee4121091199b76b3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to