Michael Pasternak has posted comments on this change.
Change subject: restapi: #864991 - Vm Custom Properties Ignored
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 207: }
Line 208:
Line 209: @Override
Line 210: public Response start(Action action) {
Line 211: RunVmOnceParams params = map(get(), new
RunVmOnceParams(guid));
using get() will invoke two additional queries to the backend to retrieve
Payload and Ballooning, while Payload can be huge up to 64k, you do not need
it nor Ballooning to run vm,
instead please run GetVmById query manually.
Line 212: if (action.isSetVm()) {
Line 213: validateEnums(VM.class, action.getVm());
Line 214: VM vm = action.getVm();
Line 215: params = map(vm, params);
--
To view, visit http://gerrit.ovirt.org/8706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9c4ac782edf1779455aeee4121091199b76b3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
