Mike Kolesnik has posted comments on this change.

Change subject: core,engine: Add NetworkView entity
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkView.java
Line 44:     @Override
Line 45:     public int hashCode() {
Line 46:         final int prime = 31;
Line 47:         int result = 1;
Line 48:         result = prime * result + ((compatibilityVersion == null) ? 0 
: compatibilityVersion.hashCode());
Actually Eclipse does have an option to use getters instead of direct field 
access
Line 49:         result = prime * result + ((network == null) ? 0 : 
network.hashCode());
Line 50:         result = prime * result + ((storagePoolName == null) ? 0 : 
storagePoolName.hashCode());
Line 51:         return result;
Line 52:     }


--
To view, visit http://gerrit.ovirt.org/8652
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60d5473347642ed7d96c89accd675977dd86e017
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to