Moti Asayag has posted comments on this change.
Change subject: core,engine: Add NetworkView entity
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkView.java
Line 44: @Override
Line 45: public int hashCode() {
Line 46: final int prime = 31;
Line 47: int result = 1;
Line 48: result = prime * result + ((compatibilityVersion == null) ? 0
: compatibilityVersion.hashCode());
Done.
Would you mind proposing it to Eclipse ? (this code was generated by eclipse
code generator).
Line 49: result = prime * result + ((network == null) ? 0 :
network.hashCode());
Line 50: result = prime * result + ((storagePoolName == null) ? 0 :
storagePoolName.hashCode());
Line 51: return result;
Line 52: }
Line 58: }
Line 59: if (obj == null) {
Line 60: return false;
Line 61: }
Line 62: if (getClass() != obj.getClass()) {
Done
Line 63: return false;
Line 64: }
Line 65: NetworkView other = (NetworkView) obj;
Line 66: if (compatibilityVersion == null) {
Line 62: if (getClass() != obj.getClass()) {
Line 63: return false;
Line 64: }
Line 65: NetworkView other = (NetworkView) obj;
Line 66: if (compatibilityVersion == null) {
Done
Line 67: if (other.compatibilityVersion != null) {
Line 68: return false;
Line 69: }
Line 70: } else if
(!compatibilityVersion.equals(other.compatibilityVersion)) {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkViewDaoDbFacadeImpl.java
Line 28: @Override
Line 29: public NetworkView mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 30: NetworkView entity = new NetworkView();
Line 31: Network network = new Network();
Line 32:
network.setId(Guid.createGuidFromString(rs.getString("network_id")));
Done
Line 33: network.setname(rs.getString("network_name"));
Line 34:
network.setdescription(rs.getString("network_description"));
Line 35: network.settype((Integer) rs.getObject("network_type"));
Line 36: network.setaddr(rs.getString("addr"));
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkViewDaoTest.java
Line 24: List<NetworkView> result =
Line 25: dao.getAllWithQuery(String.format("SELECT * FROM
network_view where network_id = '%s'",
Line 26: FixturesTool.EXISTING_NETWORK_ID));
Line 27:
Line 28: assertEquals(FixturesTool.EXISTING_NETWORK_ID,
result.get(0).getNetwork().getId());
Done
Line 29: }
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 55: <include name="common/businessentities/LunStatus.java"
/>
Line 56: <include
name="common/businessentities/network_cluster.java" />
Line 57: <include
name="common/businessentities/NetworkClusterId.java" />
Line 58: <include name="common/businessentities/Network.java" />
Line 59: <include name="common/businessentities/NetworkView.java" />
Done
Line 60: <include
name="common/businessentities/NetworkBootProtocol.java" />
Line 61: <include
name="common/businessentities/NetworkInterface.java" />
Line 62: <include
name="common/businessentities/NetworkStatistics.java" />
Line 63: <include
name="common/businessentities/NetworkStatus.java" />
--
To view, visit http://gerrit.ovirt.org/8652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60d5473347642ed7d96c89accd675977dd86e017
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
