Daniel Erez has posted comments on this change. Change subject: core: Introduce create Cinder snapshot command ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/40977/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java: Line 51: UNUSED1 change to Unassigned Line 95: getImageDao().save(image.getImage()); Line 96: DiskImageDynamic diskDynamic = updateDiskImageDynamic(image); Line 97: ImageStorageDomainMap imageStorageDomainMap = setImageStorageDomainMap(image); Line 98: boolean isDiskAdded = saveDiskIfNotExists(image); Line 99: if (compensationContext != null) { consider to extract this logic to reuse the same logic in BaseImagesCommand Line 100: compensationContext.snapshotNewEntity(image.getImage()); Line 101: compensationContext.snapshotNewEntity(diskDynamic); Line 102: compensationContext.snapshotNewEntity(imageStorageDomainMap); Line 103: if (isDiskAdded) { Line 141: need to remember to add revert task when introducing the new infra for coco -- To view, visit https://gerrit.ovirt.org/40977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I828f61ed4892b52288256a9a1e14b2efb56140c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
