Tal Nisan has posted comments on this change. Change subject: core: check hosts statuses to determine the data center status ......................................................................
Patch Set 2: Code-Review+1 (3 comments) +1, minor comments and I'll upgrade to +2 https://gerrit.ovirt.org/#/c/39115/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 199: updateStoragePoolStatus(storagePool, StoragePoolStatus.NonResponsive, Line 200: AuditLogType.SYSTEM_CHANGE_STORAGE_POOL_STATUS_NON_RESPONSIVE_NO_REPORTING_HOSTS, Line 201: VdcBllErrors.ENGINE); Line 202: } Line 203: } else { Change to else if Line 204: if (poolStatusDeterminedByHostsStatus && storagePool.getStatus() != StoragePoolStatus.Up) { Line 205: updateStoragePoolStatus(storagePool, StoragePoolStatus.Up, Line 206: AuditLogType.SYSTEM_CHANGE_STORAGE_POOL_STATUS_UP_REPORTING_HOSTS, Line 207: null); Line 254: || (result.getSucceeded() && ((SpmStatusResult) result.getReturnValue()).getSpmStatus() != SpmStatus.SPM)) { Line 255: // update pool status to problematic until fence will happen Line 256: if (storagePool.getStatus() != StoragePoolStatus.NonResponsive Line 257: && storagePool.getStatus() != StoragePoolStatus.NotOperational) { Line 258: if (result != null && result.getVdsError() != null) { Please use updateStoragePoolStatus(...) Line 259: ResourceManager Line 260: .getInstance() Line 261: .getEventListener() Line 262: .storagePoolStatusChange(_storagePoolId, StoragePoolStatus.NonResponsive, Line 261: .getEventListener() Line 262: .storagePoolStatusChange(_storagePoolId, StoragePoolStatus.NonResponsive, Line 263: AuditLogType.SYSTEM_CHANGE_STORAGE_POOL_STATUS_PROBLEMATIC_WITH_ERROR, Line 264: result.getVdsError().getCode()); Line 265: } else { Please use updateStoragePoolStatus(...) Line 266: ResourceManager Line 267: .getInstance() Line 268: .getEventListener() Line 269: .storagePoolStatusChange(_storagePoolId, StoragePoolStatus.NonResponsive, -- To view, visit https://gerrit.ovirt.org/39115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifff7325686c3e4034c9ab417d98583c7119cefae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
