Vojtech Szocs has posted comments on this change. Change subject: core, webadmin: Dismissible events ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41382/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java: Line 213: } Line 214: Line 215: public void clearAllDismissedEvents() { Line 216: ClearDismissedAuditLogsBySeverityParameters params = new ClearDismissedAuditLogsBySeverityParameters( Line 217: Arrays.asList( > IIUC, AuditLogSeverity groups two logical entities - events with: Or maybe just do something like: public enum AuditLogSeverity implements Identifiable { ... public static final List<AuditLogSeverity> EVENTS = Collections.unmodifiableList(Arrays.asList(NORMAL, WARNING, ERROR)); public static final List<AuditLogSeverity> ALERTS = Collections.singletonList(ALERT); ... } Line 218: AuditLogSeverity.ERROR, Line 219: AuditLogSeverity.WARNING, Line 220: AuditLogSeverity.NORMAL Line 221: )); -- To view, visit https://gerrit.ovirt.org/41382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibae6686f24dcf6afc1fb0db48d803176dd318d88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
