Roy Golan has posted comments on this change.

Change subject: core: Inject AutoStartVmsRunner and make it a BackendService
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/41040/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java:

Line 72:     @PostConstruct
Line 73:     private void init() {
Line 74:         int autoStartVmsRunnerIntervalInSeconds =
Line 75:                 
Config.<Integer>getValue(ConfigValues.AutoStartVmsRunnerIntervalInSeconds);
Line 76:         SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(
> did you plan to use schedulerUtil here?
sure, good catch, its a merge problem. I added it in the last patch. I'll fixup 
this commit and resend
Line 77:                 this,
Line 78:                 "startFailedAutoStartVms",
Line 79:                 new Class[] {},
Line 80:                 new Object[] {},


-- 
To view, visit https://gerrit.ovirt.org/41040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fdf736e8ae33b8b55a6f6294dc0cca4a2603897
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to