Shubhendu Tripathi has posted comments on this change. Change subject: engine, webadmin: Disable add/remove bricks for EC volumes ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41053/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java: Line 197: if (volumeEntity == null || getSelectedItems() == null || getSelectedItems().size() == 0) { Line 198: allowRemove = false; Line 199: allowReplace = false; Line 200: allowAdvanced = false; Line 201: allowAdd = false; > This forces the uses to select a brick then add brick Oh sorry! will remove this line. Only volumeType check is required to disable the add button. Line 202: } Line 203: else { Line 204: GlusterAsyncTask volumeTask = volumeEntity.getAsyncTask(); Line 205: if (volumeTask != null -- To view, visit https://gerrit.ovirt.org/41053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96714b4faea8f0f1c29cb5ef4426b8c4a2a7ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
