Ramesh N has posted comments on this change. Change subject: engine, webadmin: Disable add/remove bricks for EC volumes ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41053/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java: Line 59: isDistributedDispersedType() getVolumeType().isDispersedType() itself should take care of the distributed disperse types. see the imple of isDispersedType(). public boolean isDispersedType() { return value().contains("DISPERSE"); } https://gerrit.ovirt.org/#/c/41053/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java: Line 218: volumeEntity.getVolumeType() why not just volumeEntity.getVolumeType().isDispersedType() -- To view, visit https://gerrit.ovirt.org/41053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96714b4faea8f0f1c29cb5ef4426b8c4a2a7ffa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
